optimize engine cache checker #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个PR #541 可以删掉了... |
|
直接close就好
DuodenumL ***@***.***>于2022年1月21日 周五18:52写道：
这个PR #541 <#541> 可以删掉了...
—
Reply to this email directly, view it on GitHub
<#542 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD3S2H3HAQRJZWH452CFFDUXE3GDANCNFSM5MPGEB5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
- CMGS
|
DuodenumL
force-pushed
the
release/v22.01.05
branch
from
bc661cc to
a62ff3c
Compare
|
求Merge |
|
可以直接从 branch merge 到 master: master...v22.01.05 |
试过，可能是因为我之前有分别在master和branch各提了一个PR，虽然改动基本相同，但是commit id不一样，导致不能顺畅地rebase... 如果是这样的话，以后的hotfix / patch我就只先提PR到branch，然后通过测试了再rebase到master上去，应该可以避免这种问题 |
jschwinger233
approved these changes
Jan 26, 2022
|
so what should I do |
|
留给老板点合并 这样github profile里的contribution会比较好看( |
|
我的十字架从 100% commit 变成了 100% review…… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
同#539
P.S. 应该是因为我之前有个改动提了2个PR，分别到master和v21.01.05的某个alpha版本，导致直接git rebase v21.01.05再提PR出现一大堆commits，感觉这样是不太合理的。以后应该只提1个PR到alpha版本，等QA测完了再合并到master去。